Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDMS-200 captures ched types of movements & adds to analytics. One of… #36

Merged
merged 9 commits into from
Jan 2, 2025
Merged

CDMS-200 captures ched types of movements & adds to analytics. One of… #36

merged 9 commits into from
Jan 2, 2025

Conversation

craigedmunds
Copy link
Contributor

… the tests is failing so needs investigation

@craigedmunds craigedmunds force-pushed the feature/cdms-200-finishing-decision-analytics branch from 413199b to a5d6df6 Compare January 2, 2025 12:46
@craigedmunds craigedmunds force-pushed the feature/cdms-200-finishing-decision-analytics branch from a5d6df6 to cbe21c4 Compare January 2, 2025 13:09
@craigedmunds craigedmunds force-pushed the feature/cdms-200-finishing-decision-analytics branch from dd780c3 to 1014f0a Compare January 2, 2025 15:23
t11omas
t11omas reviewed Jan 2, 2025
View reviewed changes
Btms.Business/Extensions/ImportNotificationTypeEnumExtensions.cs
public static ImportNotificationTypeEnum? GetChedType(this string documentCode)
{
//This is the mapping from https://eaflood.atlassian.net/wiki/spaces/ALVS/pages/5177016349/DocumentCode+Field
return documentCode switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If document code is not part of the switch, should we be returning null. What scenario would an invalid document code be valid

@craigedmunds craigedmunds marked this pull request as ready for review January 2, 2025 16:51
@craigedmunds craigedmunds force-pushed the feature/cdms-200-finishing-decision-analytics branch from 09fe2ea to 26c10f4 Compare January 2, 2025 17:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Code Coverage

Package Line Rate Branch Rate Health
Btms.Business 72% 53% ➖
Btms.Types.Gvms.Mapping 38% 26% ❌
Btms.Metrics 82% 0% ✔
Btms.Types.Gvms 67% 100% ➖
Btms.Types.Alvs.Mapping 76% 0% ➖
Btms.Types.Ipaffs.Mapping 74% 37% ➖
TestDataGenerator 70% 67% ➖
Btms.Azure 43% 75% ❌
Btms.BlobService 33% 23% ❌
Btms.Backend.Data 65% 61% ➖
Btms.Consumers 78% 70% ➖
Btms.Common 82% 50% ✔
Btms.Model 91% 97% ✔
Btms.SyncJob 73% 62% ➖
Btms.SensitiveData 80% 83% ✔
Btms.Types.Ipaffs 95% 61% ✔
Btms.Types.Alvs.Mapping.V1.Tests 0% 0% ❌
Btms.Types.Alvs 84% 50% ✔
Btms.Emf 11% 6% ❌
Btms.Backend 64% 47% ➖
Btms.Analytics 74% 61% ➖
Summary 74% (7439 / 10111) 53% (686 / 1292) ➖

@craigedmunds craigedmunds merged commit a80c298 into main Jan 2, 2025
1 check passed
@craigedmunds craigedmunds deleted the feature/cdms-200-finishing-decision-analytics branch January 2, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t11omas t11omas t11omas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigedmunds @t11omas